Don't handle errors when committing the completion
authorFederico Mena Quintero <federico@novell.com>
Fri, 23 Jan 2009 00:53:53 +0000 (00:53 +0000)
committerFederico Mena Quintero <federico@src.gnome.org>
Fri, 23 Jan 2009 00:53:53 +0000 (00:53 +0000)
(commit_completion_and_refresh): Don't do anything with the result
of refresh...(), since this function doesn't get called during
completion-related interaction.

Signed-off-by: Federico Mena Quintero <federico@novell.com>
svn path=/trunk/; revision=22179

ChangeLog
gtk/gtkfilechooserentry.c

index d3e285830ff8197d5e0839c31906ead873ab74ef..5302759f95ab06e1c727691fe902c5c50c5f865b 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -29,6 +29,9 @@
        (start_explicit_completion): Process the result from
        refresh...().  Here we present the actual feedback about only
        being able to display local folders for local_only=TRUE.
+       (commit_completion_and_refresh): Don't do anything with the result
+       of refresh...(), since this function doesn't get called during
+       completion-related interaction.
        
 2009-01-22  Matthew Barnes  <mbarnes@redhat.com>
 
index fabc23b9f046a6c5c27419661b6a388ce48b1ddb..30dcb61385ce4fe6515b273ec48bf54106206e8d 100644 (file)
@@ -1246,7 +1246,7 @@ commit_completion_and_refresh (GtkFileChooserEntry *chooser_entry)
                                 GTK_ENTRY (chooser_entry)->text_length);
     }
 
-  /* FMQ: get result from the function below */
+  /* Here we ignore the result of refresh_current_folder_and_file_part(); there is nothing we can do with it */
   refresh_current_folder_and_file_part (chooser_entry, REFRESH_WHOLE_TEXT);
 }
 
@@ -1759,12 +1759,11 @@ _gtk_file_chooser_entry_set_base_folder (GtkFileChooserEntry *chooser_entry,
  * @chooser_entry: a #GtkFileChooserEntry
  *
  * Gets the current folder for the #GtkFileChooserEntry. If the
- * user has only entered a filename, this will be the base folder
+ * user has only entered a filename, this will be in the base folder
  * (see _gtk_file_chooser_entry_set_base_folder()), but if the
  * user has entered a relative or absolute path, then it will
- * be different. If the user has entered a relative or absolute
- * path that doesn't point to a folder in the file system, it will
- * be %NULL.
+ * be different.  If the user has entered unparsable text, or text which
+ * the entry cannot handle, this will return %NULL.
  *
  * Return value: the file for the current folder - this value is owned by the
  *  chooser entry and must not be modified or freed.